Skip to content

Add env-var for image-name and manual dispatch to build workflow#373

Open
Wuodan wants to merge 3 commits intonikolaik:mainfrom
Wuodan:upstream-PR/00-workflow-test-nobs
Open

Add env-var for image-name and manual dispatch to build workflow#373
Wuodan wants to merge 3 commits intonikolaik:mainfrom
Wuodan:upstream-PR/00-workflow-test-nobs

Conversation

@Wuodan
Copy link

@Wuodan Wuodan commented Mar 17, 2026 •
edited
Loading

These are some small changes to allow

  • overriding the image-name in forks github action settings for tests
  • trigggering the "Deploy" workflow manually in GitHub for tests

My other PRs will include these 2 base commits, you or others may find them useful too.

Background:
Seeing that OpenHands uses one of these images as base image, I originally wanted to use these images for project aicage as base-image and for a util-image.
But I ended up not using python-nodejs mainly because I wanted a latest tag and this was missing for arm64.
My PRs here are merely things for image-building in GitHub workflow which I couild easily transfer back from project aicage.

Wuodan added 2 commits March 17, 2026 02:30
@Wuodan
Make workflow image name overrideable from Actions vars
7ca4944 
Keep nikolaik/python-nodejs as the default image name in the workflow, but resolve it through a GitHub Actions variable so forks can publish to a different image without changing the repository.

Forks can set IMAGE_NAME in Actions variables or in workflow run configuration. That keeps the default behavior unchanged here while avoiding fork-specific edits in PRs.
@Wuodan
Add manual deploy trigger with run-time overrides
e59a27e 
Allow manual workflow runs from GitHub Actions with a force option and an optional IMAGE_NAME override.
This makes it possible to test publish flows without overwriting the real published images tags.
This was referenced Mar 17, 2026
Closed
Open
Open
nikolaik
nikolaik reviewed Mar 18, 2026
View reviewed changes
Copy link
Owner

@nikolaik nikolaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your PRs Stefan <3

Made a few stylistic comments on this one

@Wuodan
Refine build workflow inputs and shell formatting
5dfaea9 
Address review feedback on PR nikolaik#373 by renaming the manual image override input and reformatting long shell commands for readability.
@Wuodan
Copy link
Author

Wuodan commented Mar 18, 2026 •
edited
Loading

Thank you for this open source repo!

I updated this PR #373 and merged the changes into the other 2 PRs #375 and #377 with a small fix in #375.

Test-runs:

PR Branch GH Action Run Image Repository
#373 upstream-PR/00-workflow-test-nobs 23243561023 wuodan/python-nodejs_pr00
#375 upstream-PR/02-replace-qemu-with-arm64-runner 23243601563 wuodan/python-nodejs_pr02
#377 upstream-PR/04-fix-latest-tag-missing-for-arm64 23243613553 wuodan/python-nodejs_pr04
  • Failures in the final job Update versions.json and README.md are due to running the action with non-main branch.
    It works with main branch (example action-run).
  • Durations of the above GH Action Runs are not representative as all ran in parallel and there is a limit of max. 20 parallel jobs per GitHub repo.
  • In my tests with QEMU a full run takes ~30min while with arm64 GH runners it takes ~20min.

Run 23243601563 needed a restart with "Re-run failed jobs" because one job was canceled with error:

##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

GH actions are not fully reliable, I've seen such random failures or network problems before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikolaik nikolaik nikolaik left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wuodan @nikolaik